Add disk_encryption_set for data disks in azure_rm_virtualmachine #1309
Conversation
Fred-sun
added
enhancement
|
@ephracis Please fix the conflict in the document! Thank you very much! |
Add the parameter `data_disks.disk_encryption_set` to the `azure_rm_virtualmachine` module, making it possible to specify which DES to use when encrypting the data disk. This is required when creating a VM (with data disks) from an encrypted image which resides in another landing zone.
ephracis
force-pushed
the
add-virtualmachine-data-encryption-set
branch
from
845db86 to
8888585
Compare
Done! |
| @@ -1865,6 +1869,10 @@ def exec_module(self, **kwargs): | |||
| else: | |||
| data_disk_vhd = None | |||
| data_disk_managed_disk = self.compute_models.ManagedDiskParameters(storage_account_type=data_disk['managed_disk_type']) | |||
| if data_disk.get('disk_encryption_set'): | |||
There was a problem hiding this comment.
Does it mean that 'disk_encryption_set' can only be specified if 'managed_disk_type' is not configured for data_disks(self.data_disks.get('managed_disk_type')=None)?
There was a problem hiding this comment.
I think so. I'm not an expert at Azure but from what I can see, it is only the class ManagedDiskParameters which has the parameter disk_encryption_set as per the Azure Python SDK: https://learn.microsoft.com/en-us/python/api/azure-mgmt-compute/azure.mgmt.compute.v2023_07_01.models.manageddiskparameters?view=azure-python
I'm not sure if other types of disk can be encrypted using a DES. That might be the case. But for example my current customer has a use case where they use managed disk and need encryption with CMK. This would solve that use case at least.
|
@ephracis Please add 'disk_encryption_set' to argument. Thank you very much! |
Fred-sun
added
ready_for_review
|
@ephracis LGTM 🚢 |
SUMMARY
Add the parameter
data_disks.disk_encryption_setto theazure_rm_virtualmachinemodule, making it possible to specify which DES to use when encrypting the data disk.ISSUE TYPE
COMPONENT NAME
azure_rm_virtualmachine
ADDITIONAL INFORMATION
This is required when creating a VM (with data disks) from an encrypted image which resides in another landing zone.